| Summary: | rpmlint should be align with rosa packaging policy and not mandriva's | ||
|---|---|---|---|
| Product: | [ROSA-based products] ROSA Fresh | Reporter: | symbianflo <symbianflo> |
| Component: | Packages from Main | Assignee: | ROSA Linux Bugs <bugs> |
| Status: | RESOLVED FIXED | QA Contact: | ROSA Linux Bugs <bugs> |
| Severity: | normal | ||
| Priority: | Normal | CC: | alexander.kazantsev, denis.silakov, symbianflo |
| Version: | Marathon | ||
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Platform: | --- | ROSA Vulnerability identifier: | |
| RPM Package: | rpmlint-1.2-2 in 2012.0 and rpmlint-1.4-20 in 2012.1 | ISO-related: | |
| Bad POT generating: | Upstream: | ||
(In reply to comment #0) > > - W: non-standard-group Video > ( align with the packaging groups) > > - W: no-cleaning-of-buildroot %install > - W: no-cleaning-of-buildroot %clean > - W: no-buildroot-tag > ( obsoletes in rpm5) Hm, have you installed rpmlint-mandriva-policy package? It should provide you with /usr/share/rpmlint/config.d/mandriva.conf file which will filter at least the buildroot warnings, and maybe some others. Surely, it would be better to create our own rpmlint-rosa-policy package, but maybe installing rpmlint-mandriva-policy will solve some of your problems? (In reply to comment #0) > > - W: non-coherent-filename rosa-media-player-1.0-3.x86_64.rpm > rosa-media-player-1.0-3-rosa.lts2012.0.x86_64.rpm > The file which contains the package should be named > <NAME>-<VERSION>-<RELEASE>.<ARCH>.rpm. > ( missing dist suffix? ) This one is fixed for 2012.1. Not sure if it is serious enough to backport it to 2012lts. Finally, if you use ROSA itself to build packages, you shouldn't get this warning at all. We don't backport change to 2012lts. We use in it rules from Mandriva 2011. We don't create rosa-rules - we still use rules from Mandriva Cooker and all fix need be in Cooker, then moving to ROSA. We sync with Mandriva rpm, rules and etc. (In reply to comment #1) > (In reply to comment #0) > > > > - W: non-standard-group Video > > ( align with the packaging groups) > > > > - W: no-cleaning-of-buildroot %install > > - W: no-cleaning-of-buildroot %clean > > - W: no-buildroot-tag > > ( obsoletes in rpm5) > > Hm, have you installed rpmlint-mandriva-policy package? It should provide > you with /usr/share/rpmlint/config.d/mandriva.conf file which will filter at > least the buildroot warnings, and maybe some others. > > Surely, it would be better to create our own rpmlint-rosa-policy package, > but maybe installing rpmlint-mandriva-policy will solve some of your > problems? yes, as I can see installing rpmlint-mandriva-policy it fix the warning related to packaging groups and buildroot warnings. rpmlint-mandriva-policy should be included ,along rpmlint , in the jail's structure on ABF , IMHO . Less useless warnings and errors . and also why rpmlint-mandriva-policy is not included in rpmlint's requires on rosa ,then ? Or at least could be mentioned Here: http://wiki.rosalab.ru/en/index.php/Packaging_HowTo#Linting_the_package Honestly, I didn't even knew about the existence of this rpmlint-mandriva-policy package . (In reply to comment #5) > Less useless warnings and errors . and also why rpmlint-mandriva-policy is > not included in rpmlint's requires on rosa ,then ? rpmlint 'suggests' rpmlint-mandriva-policy. The thing is that in 2012lts rpmlint-mandriva-policy is located in the contrib repo which is not enabled by default. In 2012.1 it was moved to main. > Or at least could be mentioned Here: > http://wiki.rosalab.ru/en/index.php/Packaging_HowTo#Linting_the_package Yes, I will add a note. (In reply to comment #3) > We don't backport change to 2012lts. We use in it rules from Mandriva 2011. > We don't create rosa-rules - we still use rules from Mandriva Cooker and all > fix need be in Cooker, then moving to ROSA. > > We sync with Mandriva rpm, rules and etc. It's not a problem, I push all my rpmlint-related changes to mdv. Though I don't see any problems in having patches for rpmlint of our own. (In reply to comment #6) > (In reply to comment #5) > > Less useless warnings and errors . and also why rpmlint-mandriva-policy is > > not included in rpmlint's requires on rosa ,then ? > > rpmlint 'suggests' rpmlint-mandriva-policy. The thing is that in 2012lts > rpmlint-mandriva-policy is located in the contrib repo which is not enabled > by default. In 2012.1 it was moved to main. > > > Or at least could be mentioned Here: > > http://wiki.rosalab.ru/en/index.php/Packaging_HowTo#Linting_the_package > > Yes, I will add a note. > > (In reply to comment #3) > > We don't backport change to 2012lts. We use in it rules from Mandriva 2011. > > We don't create rosa-rules - we still use rules from Mandriva Cooker and all > > fix need be in Cooker, then moving to ROSA. > > > > We sync with Mandriva rpm, rules and etc. > > It's not a problem, I push all my rpmlint-related changes to mdv. Though I > don't see any problems in having patches for rpmlint of our own. Thank you very much. Maybe should be switched from "suggest" to "Requires" even if will be in main Thanks again Ok, the only remaining warning under discussion is "spelling-error"; there doesn't seem to be any consensus on this one, so leaving it in default configuration for now. Notes about 'rpmlint-mandriva-policy' package are added to wiki, as well. Thank you again, It can be closed, AFIC. Before rpmlint-mandriva-policy: 0 packages and 1 specfiles checked; 0 errors, 4 warnings. ######### After installing rpmlint-mandriva-policy: 0 packages and 1 specfiles checked; 0 errors, 0 warnings. Thanks again. |
Description of problem: should be align with rosa packaging policy and not mandriva's Version-Release number of selected component (if applicable): rpmlint-1.2-2 rpmlint-1.4-20 How reproducible: rpmlint -i %name, rmplint -i %specfile - W: non-standard-group Video ( align with the packaging groups) - W: no-cleaning-of-buildroot %install - W: no-cleaning-of-buildroot %clean - W: no-buildroot-tag ( obsoletes in rpm5) - W: non-coherent-filename rosa-media-player-1.0-3.x86_64.rpm rosa-media-player-1.0-3-rosa.lts2012.0.x86_64.rpm The file which contains the package should be named <NAME>-<VERSION>-<RELEASE>.<ARCH>.rpm. ( missing dist suffix? ) -W: no-packager-tag There is no Packager tag in your package. You have to specify a packager using the Packager tag. Ex: Packager: John Doe <john.doe at example.com>. - W: no-changelogname-tag (autosign on ABF and git commits tracking system makes those too obsoletes) - W: spelling-error %description -l en_US ncurses -> nurses, curses, n curses ( spelling err. should be eliminate IMHO for obvious reasons ) 2012.1: E: no-packager-tag (Badness: 1) ( even worse here, treated as error..)