Bug 3984

Summary: Fix rpmbuild remove empty files left after unsuccessful download attempts
Product: [ROSA-based products] ROSA Fresh Reporter: Denis Silakov <denis.silakov>
Component: Packages from MainAssignee: ROSA Linux Bugs <bugs>
Status: RESOLVED FIXED QA Contact: ROSA Linux Bugs <bugs>
Severity: normal    
Priority: Normal CC: alex.burmashev, firstlevel, v.potapov
Version: unspecifiedFlags: v.potapov: qa_verified+
alex.burmashev: published+
Target Milestone: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Platform: --- ROSA Vulnerability identifier:
RPM Package: rpmbuild ISO-related:
Bad POT generating: Upstream:

Description Denis Silakov 2014-04-18 14:42:23 MSK
We have a tricky problem with rpmbuild using external wget to download sources - if wget cannot download a file, it creates an empty file. This can confuse other tools that decide that if file is present, then everything is ok - we recently faced this problem in ABF where mock-urpm managed to build a package though one of its sources was missing.
Comment 1 Denis Silakov 2014-04-18 14:43:33 MSK
Advisory:
Fixed rpmbuild remove empty files left after unsuccessful download attempts.

We have checked that this fix really fixes the problem in ABF, so let's just check that there are no regressions for ordinary users.


Build lists:
https://abf.io/build_lists/1798561
https://abf.io/build_lists/1798562
Comment 2 Vladimir Potapov 2014-04-23 11:15:22 MSK
The update route to extended testing
Comment 3 FirstLevel 2014-04-23 14:29:21 MSK
*****************************
Extended testing report
*****************************
I have updated my system successfully.
Log of urpmi --auto-update I have sent to Vladimir Potapov
Comment 4 Vladimir Potapov 2014-04-23 15:14:56 MSK
rpm-5.4.10-27
http://abf-downloads.rosalinux.ru/rosa2012.1/container/1798561/i586/main/release/
http://abf-downloads.rosalinux.ru/rosa2012.1/container/1798562/x86_64/main/release/
**************************** Advisory *************************
Fixed rpmbuild remove empty files left after unsuccessful download attempts.

We have checked that this fix really fixes the problem in ABF, so let's just check that there are no regressions for ordinary users.
***************************************************************
QA Verified