Bug 14416

Summary: RTL8168 non-stable work
Product: [ROSA-based products] ROSA Fresh Reporter: Vladimir Potapov <v.potapov>
Component: Hardware-specific, driversAssignee: Mikhail Novosyolov <m.novosyolov>
Status: VERIFIED FIXED QA Contact: ROSA Linux Bugs <bugs>
Severity: normal    
Priority: Normal CC: a.betkher, a.proklov
Version: XFCEFlags: v.potapov: qa_verified+
a.proklov: published+
Target Milestone: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Platform: --- ROSA Vulnerability identifier:
RPM Package: ISO-related:
Bad POT generating: Upstream:
Bug Depends on:    
Bug Blocks: 14428    
Attachments: probe for slable work
probe for non-stable work

Description Vladimir Potapov 2024-04-12 17:03:14 MSK

    
Comment 1 Vladimir Potapov 2024-04-12 17:03:58 MSK
Created attachment 6079 [details]
probe for slable work
Comment 2 Vladimir Potapov 2024-04-12 17:04:18 MSK
Created attachment 6080 [details]
probe for non-stable work
Comment 3 Vladimir Potapov 2024-04-12 17:09:44 MSK
with second probe DMESG:
r8168 0000:09:00.0: invalid VPD tag 0x00 (size 0) at offset 0; assume missing optional EEPROM
Comment 4 Vladimir Potapov 2024-04-15 09:35:44 MSK
С той же карты проба с ядром 6.6.21
https://linux-hardware.org/?probe=930f540c90

У таких же карт есть пробы с работающей сетью
ubuntu 22.10 R8169 
ubuntu 23.10 r8169
fedora 28  r8169
openSUSE Tumblew r8169
Manjaro 20.0.3 r8169
Comment 5 Vladimir Potapov 2024-04-15 09:52:02 MSK
Выше была rtl8168g-2.fw
Теперь другая проблемная карта rtl8168h-2.fw
https://linux-hardware.org/?probe=e27e00184c
Manjaro R8169 https://linux-hardware.org/?probe=fac1d1b119
Fedora 38 r8169 https://linux-hardware.org/?probe=678c17756d
Mint 21  r8169 https://linux-hardware.org/?probe=f427764e2c
ubuntu 22.04 r8169 https://linux-hardware.org/?probe=49e514e9c4
suse 15.2 r8168 https://linux-hardware.org/?probe=0c05fbff9c

Итого - только в suse, как и мы, экспериментировали с r8168
Comment 6 Vladimir Potapov 2024-04-15 10:10:13 MSK
Следующая проблемная карта rtl8168f-1.fw
https://linux-hardware.org/?probe=91919808a7
fedora35 R8169 https://linux-hardware.org/?probe=76a80df275
SUSE tw R8169 https://linux-hardware.org/?probe=7a2d061568
MINT 21 r8169 https://linux-hardware.org/?probe=584c9e1aea
ubuntu 22.04 R8169 https://linux-hardware.org/?probe=e821b0d96a
Comment 7 Mikhail Novosyolov 2024-04-16 17:50:48 MSK
Еще проблемное оборудование:
https://linux-hardware.org/?probe=5840160986

Сеть отваливается - интерфейс поднят, но пакеты перестают ходить, в dmesg:
[Вт апр 16 17:42:36 2024] workqueue: rtl8168_linkchg_task [r8168] hogged CPU for >10000us 4 times, consider switching to WQ_UNBOUND

Ревизия 16, фирмваря rtl8168h-2.fw
Comment 8 Mikhail Novosyolov 2024-04-16 19:43:37 MSK
Попробовал запатчить так, не помогло:

diff --git a/src/r8168.h b/src/r8168.h
index f3b7989..5ca523f 100755
--- a/src/r8168.h
+++ b/src/r8168.h
@@ -43,11 +43,9 @@
 #include "r8168_lib.h"
 #endif
 
-/*
 #if LINUX_VERSION_CODE >= KERNEL_VERSION(4,12,0)&& !defined(ENABLE_LIB_SUPPORT)
 #define RTL_USE_NEW_INTR_API
 #endif
-*/
 
 #if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,32)
 typedef int netdev_tx_t;

Откат до старой версии драйвера помог:
https://abf.io/import/r8168/commit/b4c03dd969a1b6140948b4105382f6752796cbca
Comment 9 Mikhail Novosyolov 2024-04-16 20:32:42 MSK
r8168 8.051.02-6
- reverted to previous version
- bumped epoch
https://abf.io/build_lists/5023069
https://abf.io/build_lists/5023076
https://abf.io/build_lists/5023074
https://abf.io/build_lists/5023107
https://abf.io/build_lists/5023108

kernel-source-nwfermi 0-0.git8bbe39.6
- added one support of one more device (touch panel)
https://abf.io/build_lists/5023071
https://abf.io/build_lists/5023073
https://abf.io/build_lists/5023075
https://abf.io/build_lists/5023077
https://abf.io/build_lists/5023078

nwfermi 0-0.git8bbe39.6 (non-free)
- added one support of one more device (touch panel)
https://abf.io/build_lists/5023109
https://abf.io/build_lists/5023110
https://abf.io/build_lists/5023111
https://abf.io/build_lists/5023112
https://abf.io/build_lists/5023113

kernel-6.1
- minor update
- updates of r8168 and nwfermi modules
https://abf.io/build_lists/5023115

kernel-6.6
- minor update
- updates of r8168 and nwfermi modules
https://abf.io/build_lists/5023114
Comment 10 Mikhail Novosyolov 2024-04-16 20:34:09 MSK
Забыл, нужно еще нужно связанную с XFS правку в конфиг ядра внести.
Comment 11 Mikhail Novosyolov 2024-04-16 20:35:23 MSK
Ее будем нвосить только в 6.6. 6.1 по ссылке выше можнло забирать, 6.6 пока не надо.
Comment 12 Mikhail Novosyolov 2024-04-16 21:59:03 MSK
(In reply to Mikhail Novosyolov from comment #7)
> Еще проблемное оборудование:
> https://linux-hardware.org/?probe=5840160986
> 
> Сеть отваливается - интерфейс поднят, но пакеты перестают ходить, в dmesg:
> [Вт апр 16 17:42:36 2024] workqueue: rtl8168_linkchg_task [r8168] hogged CPU
> for >10000us 4 times, consider switching to WQ_UNBOUND
> 
> Ревизия 16, фирмваря rtl8168h-2.fw

Проверил на 6.1 (https://abf.io/build_lists/5023115) и 6.6 (https://abf.io/build_lists/5023114) с r8168 8.051.02, сеть работает нормально.
Comment 13 Vladimir Potapov 2024-04-17 12:44:19 MSK
(In reply to Mikhail Novosyolov from comment #9)
> r8168 8.051.02-6
> - reverted to previous version
> - bumped epoch
> https://abf.io/build_lists/5023069
> https://abf.io/build_lists/5023076
> https://abf.io/build_lists/5023074
> https://abf.io/build_lists/5023107
> https://abf.io/build_lists/5023108
> 
> kernel-source-nwfermi 0-0.git8bbe39.6
> - added one support of one more device (touch panel)
> https://abf.io/build_lists/5023071
> https://abf.io/build_lists/5023073
> https://abf.io/build_lists/5023075
> https://abf.io/build_lists/5023077
> https://abf.io/build_lists/5023078
> 
> nwfermi 0-0.git8bbe39.6 (non-free)
> - added one support of one more device (touch panel)
> https://abf.io/build_lists/5023109
> https://abf.io/build_lists/5023110
> https://abf.io/build_lists/5023111
> https://abf.io/build_lists/5023112
> https://abf.io/build_lists/5023113
> 
> kernel-6.1
> - minor update
> - updates of r8168 and nwfermi modules
> https://abf.io/build_lists/5023115
********************************************
The update sent to testings
Comment 14 Vladimir Potapov 2024-04-24 16:14:20 MSK
r8168-8.051.02-6
https://abf.io/build_lists/5023069
https://abf.io/build_lists/5023076
https://abf.io/build_lists/5023074
https://abf.io/build_lists/5023107
https://abf.io/build_lists/5023108

kernel-source-nwfermi-0-0.git8bbe39.6
https://abf.io/build_lists/5023071
https://abf.io/build_lists/5023073
https://abf.io/build_lists/5023075
https://abf.io/build_lists/5023077
https://abf.io/build_lists/5023078

nwfermi-0-0.git8bbe39.6
https://abf.io/build_lists/5023109
https://abf.io/build_lists/5023110
https://abf.io/build_lists/5023111
https://abf.io/build_lists/5023112
https://abf.io/build_lists/5023113

kernel-6.1-generic-6.1.86-1
https://abf.io/build_lists/5023115
****************************** Advisory ********************************
reverted to previous version r8168
added one support of one more device (touch panel) for nwfermi
*************************************************************************
QA Verified