Bug 12822

Summary: Termhelper totally broken on Italian locale
Product: [ROSA-based products] ROSA Fresh Reporter: Giovanni Mariani <mc2374>
Component: Packages from MainAssignee: ROSA Linux Bugs <bugs>
Status: VERIFIED FIXED QA Contact: ROSA Linux Bugs <bugs>
Severity: major    
Priority: High CC: a.betkher, a.proklov, pastordidi, v.potapov
Version: AllFlags: v.potapov: qa_verified+
a.proklov: published+
Target Milestone: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Platform: 2021.1 ROSA Vulnerability identifier:
RPM Package: termhelper-0.3-20221101.1.src.rpm ISO-related:
Bad POT generating: Upstream:

Description Giovanni Mariani 2022-11-03 23:08:39 MSK
I don't know how I managed to install termhelper, but on my setup with italian lang is really broken: after installing it every konsole is cluttered by error messages:
*************************
ls: impossibile accedere a '/usr/share/termhelper/it': File o directory non esistente [translation: unable to access to '/usr/share/termhelper/it': File or directory not found]
ls: impossibile accedere a '/usr/share/termhelper/it': File o directory non esistente
ls: impossibile accedere a '/usr/share/termhelper/it': File o directory non esistente 
basename: operando mancante [translation: missing operand]
Try 'basename --help' for more information.
Uso: grep [OPZIONE]... MODELLI [FILE]...
Usare "grep --help" per ulteriori informazioni.

"header" not found
ls: impossibile accedere a '/usr/share/termhelper/it': File o directory non esistente
basename: operando mancante
Try 'basename --help' for more information.
basename: operando mancante
Try 'basename --help' for more information.
giovanni@Rivendell ~ $ 
*************************

Looking at the package spec file shows that it supports only English and Russian. IMHO, as minimum, it would be better prominently warn the user about this to avoid not-so-pleasant surprises in Main...

Given that the package idea looks good, with some advice about how do it I could be also lured in adding Italian support :-)
Comment 1 a.betkher 2022-11-05 18:41:49 MSK
Thanks for bug report!
Check this package, please. 

https://file-store.rosalinux.ru/api/v1/file_stores/06a1e0892fa20d573888e942edbe5d53b8e4d31c

If you translate some pages into Italian, we add them to the project.
Comment 2 a.betkher 2022-11-05 18:50:37 MSK
https://abf.io/build_lists/4173584 - x86_64
https://abf.io/build_lists/4173585 - aarch
https://abf.io/build_lists/4173586 - i686
https://abf.io/build_lists/4173588 - risc

Advisory:
- check with unknown locale: LANG=bla-bla xterm
Comment 3 Giovanni Mariani 2022-11-05 18:56:51 MSK
(In reply to a.betkher from comment #1)
> Thanks for bug report!
> Check this package, please. 
> 
> https://file-store.rosalinux.ru/api/v1/file_stores/
> 06a1e0892fa20d573888e942edbe5d53b8e4d31c
> 
> If you translate some pages into Italian, we add them to the project.

Glad to help...
What stuff need a translation?
Comment 4 a.betkher 2022-11-05 19:14:15 MSK
> What stuff need a translation?

Help pages here:
https://github.com/betcher/termhelper/tree/main/helps

Minimum needed pages like in "en" folder, all pages available only for russian now (dir "ru"). Filenames must be in Italian too.
Comment 5 Dmitry Postnikov 2022-11-08 09:54:34 MSK
(In reply to a.betkher from comment #2)
> https://abf.io/build_lists/4173584 - x86_64
> https://abf.io/build_lists/4173585 - aarch
> https://abf.io/build_lists/4173586 - i686
> https://abf.io/build_lists/4173588 - risc
> 
> Advisory:
> - check with unknown locale: LANG=bla-bla xterm

I checked, with the locale IT is shown in EN. As soon as they create a folder with IT in Github, it will work.


****************************
The update sent to testings
Comment 6 Giovanni Mariani 2022-11-08 16:45:24 MSK
(In reply to a.betkher from comment #1)

> If you translate some pages into Italian, we add them to the project.
Added a tentative patch on ABF...
Comment 7 Vladimir Potapov 2022-11-09 12:52:07 MSK
(In reply to Giovanni Mariani from comment #6)
> Added a tentative patch on ABF...
Thank you for your help in the development! The compiled version will be sent to the repository for now, the translation will be added after debugging.
Comment 8 Vladimir Potapov 2022-11-09 12:55:01 MSK
termhelper-0.3-20221105
https://abf.io/build_lists/4173584 - x86_64
https://abf.io/build_lists/4173585 - aarch
https://abf.io/build_lists/4173586 - i686
https://abf.io/build_lists/4173588 - risc
************************ Advisory *****************************
- check with unknown locale: LANG=bla-bla xterm
***************************************************************
QA Verified
Comment 9 a.betkher 2022-11-09 12:57:24 MSK
> Added a tentative patch on ABF...

Thanks. If you don't mind, I'll transfer the files to github. Where you corrected typos in English. And from there to abf  as new source.
Comment 10 a.betkher 2022-11-09 14:49:18 MSK
> Added a tentative patch on ABF...

Sorry, I completely forgot about it:

msgid "matches several subsections"
msgstr ""

msgid "not found"
msgstr ""

msgid "Hi! Today is"
msgstr ""

msgid "Subsections"
msgstr ""

msgid "Found in"
msgstr ""

msgid "command not found"
msgstr ""

msgid "try to install one of this"
msgstr ""

#: стандартный ввод:9
msgid "Warning:"
msgstr ""

#: стандартный ввод:10
msgid "the file was found in the directory for the root  binaries"
msgstr ""

#: стандартный ввод:11
msgid ""
"you need root permissions (sudo, su -), or try to execute it with full path"
msgstr ""

Can you help us again? Here, or on github:
https://github.com/betcher/termhelper/blob/main/gettext/termhelper.po.it