Bug 12415

Summary: Promote ladish library package to Main as better lash library replacement
Product: [ROSA-based products] ROSA Fresh Reporter: Giovanni Mariani <mc2374>
Component: Packages from MainAssignee: ROSA Linux Bugs <bugs>
Status: RESOLVED FIXED QA Contact: ROSA Linux Bugs <bugs>
Severity: normal    
Priority: Normal CC: a.proklov
Version: Plasma5   
Target Milestone: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Platform: 2021.1 ROSA Vulnerability identifier:
RPM Package: ladish-1-12.src.rpm ISO-related:
Bad POT generating: Upstream:

Description Giovanni Mariani 2022-06-17 18:43:43 MSK 
The lash library, used for session management with jack sound server, is old (last release in 2009) and unmaintained (not commit in the upstream git since July 2009).

Luckily there is a viable replacement: the Nedko Arnaudov's LADI Session Handler (https://github.com/LADI/ladish).
It's a complete rewrite of lash and is much more active (last git commit wad in February 2021); it's already used by Carla and Cadence packages.

It also sports an handy lash compatibility layer (liblash): all it should be needed to convert a package from lash to ladish is changing the references to lash and its headers in those for the ladish compatibility layer and its headers.
I already tried the change for a simple package (amsynth) and a bigger one (calf): the needed patches are only 4 lines long.

Bottom line: I would like to port all the sound packages using lash to ladish (in total they are 9 or 10), but I need to have ladish in Main, while ATM is in Contrib...

Can someone with the right powers do this move for me?
Comment 1 Aleksandr Proklov 2022-06-19 07:04:32 MSK 
Hi,
1. delete lash from repo
2. move ladish to main repo and make lib64lash rpm package. Disable gladish build (gtk2 gui may be not needed?)

Need more?
Comment 3 Aleksandr Proklov 2022-06-19 08:04:58 MSK 
 seq24, dino, zynaddsubfx from contrib repo need check for build with ladish
Comment 4 Giovanni Mariani 2022-06-19 17:02:28 MSK 
(In reply to Aleksandr from comment #3)
>  seq24, dino, zynaddsubfx from contrib repo need check for build with ladish

My list has more items:
amsynth - done
aubio
calf (Main) - done
dino
fluidsynth (Main - ATM lash support is already disabled)
hydrogen - wip
seq24
timemachine
zynaddsubfx.

I will try to process all of them before going offline for trekking (I will be out of touch from 25/06 to 03/07).

> Disable gladish build (gtk2 gui may be not needed?)
I don't know: perhaps being gtk2 stuff is OK to disable it... need to check with upstream.
Comment 6 Giovanni Mariani 2022-06-21 16:41:22 MSK 
(In reply to Giovanni Mariani from comment #5)
> (In reply to Aleksandr from comment #2)
> > I rebuild caif with ladish, please check work.
> > 
> > https://abf.rosalinux.ru/build_lists/4091275
> > https://abf.rosalinux.ru/build_lists/4091276 (x64)
> > https://abf.rosalinux.ru/build_lists/4091277
> > https://abf.rosalinux.ru/build_lists/4091278
> > https://abf.rosalinux.ru/build_lists/4091279
> 
> Tried: WFM...

Update:
amsynth - done & tested locally
aubio - todo: it uses waf -> more difficult to find where to patch
calf (Main) - done & tested locally
dino - done & tested locally
hydrogen - near done: conflicts between attempted installs of ladish-1-12.x86_64 and lib64lash-devel-0.6.0-0.rc2.1.x86_64 (all providing liblash.so) while installing lib64hydrogen-devel; the main package and library install and work, though,
seq24 - done & tested locally
timemachine - done & tested locally
zynaddsubfx - near done: i686 build chokes (Segmentation fault) - don't know why.

For fluidsynth package: I will update it later to the latest 2.2.7 release and while at it do the needed changes to use ladish.
Comment 7 Aleksandr Proklov 2022-06-23 14:02:37 MSK 
zynaddsubfx please add ExcludeArch: %{ix86} and up release.

If all good, close bug? caif published to main
Comment 8 Giovanni Mariani 2022-06-23 17:57:40 MSK 
(In reply to Aleksandr from comment #7)
> zynaddsubfx please add ExcludeArch: %{ix86} and up release.
Done.

> 
> If all good, close bug? caif published to main
There is still the issue with hydrogen devel package, but the real program works without it and AFAICT no other programs are using it, so I guess we can consider this bug closed.
Comment 9 Aleksandr Proklov 2022-06-24 13:40:21 MSK 
ok, thank you!